Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756246AbcCOPcq (ORCPT ); Tue, 15 Mar 2016 11:32:46 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:11949 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754170AbcCOPcn (ORCPT ); Tue, 15 Mar 2016 11:32:43 -0400 Subject: Re: Page migration issue with UBIFS To: "Kirill A. Shutemov" References: <56E8192B.5030008@nod.at> <20160315151727.GA16462@node.shutemov.name> Cc: linux-fsdevel , "linux-mtd@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Boris Brezillon , Maxime Ripard , David Gstir , Dave Chinner , Artem Bityutskiy , "Kirill A. Shutemov" , Alexander Kaplan From: Richard Weinberger Message-ID: <56E82B18.9040807@nod.at> Date: Tue, 15 Mar 2016 16:32:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160315151727.GA16462@node.shutemov.name> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 793 Lines: 23 Am 15.03.2016 um 16:17 schrieb Kirill A. Shutemov: > On Tue, Mar 15, 2016 at 03:16:11PM +0100, Richard Weinberger wrote: >> Hi! >> >> We're facing this issue from 2014 on UBIFS: >> http://www.spinics.net/lists/linux-fsdevel/msg79941.html >> >> So sum up: >> UBIFS does not allow pages directly marked as dirty. It want's everyone to do it via UBIFS's >> ->wirte_end() and ->page_mkwirte() functions. >> This assumption *seems* to be violated by CMA which migrates pages. > > I don't thing the CMA/migration is the root cause. > > How did we end up with writable and dirty pte, but not having > ->page_mkwrite() called for the page? > > Or if ->page_mkwrite() was called, why the page is not dirty? BTW: UBIFS does not implement ->migratepage(), could this be a problem? Thanks, //richard