MIME-Version: 1.0
In-Reply-To: <1458062592-27981-2-git-send-email-appanad@xilinx.com>
References: <1458062592-27981-1-git-send-email-appanad@xilinx.com>
	<1458062592-27981-2-git-send-email-appanad@xilinx.com>
Date: Tue, 15 Mar 2016 10:50:23 -0700
Message-ID: <CAAtXAHdzgt2uXo4_BV4wbGyAbseF7JcbWf8on-KzmcDWnK+WPw@mail.gmail.com>
Subject: Re: [PATCH 1/7] dmaengine: xilinx_vdma: Fix checkpatch.pl warnings
From: Moritz Fischer <moritz.fischer@ettus.com>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
Cc: Dan Williams <dan.j.williams@intel.com>, Vinod Koul <vinod.koul@intel.com>,
        Michal Simek <michal.simek@xilinx.com>,
        =?UTF-8?Q?S=C3=B6ren_Brinkmann?= <soren.brinkmann@xilinx.com>,
        Appana Durga Kedareswara Rao <appanad@xilinx.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Luis de Bethencourt <luis@debethencourt.com>,
        Anirudha Sarangi <anirudh@xilinx.com>, dmaengine@vger.kernel.org,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 689
Lines: 27

Hi,

this patch looks fine to me.

On Tue, Mar 15, 2016 at 10:23 AM, Kedareswara rao Appana
<appana.durga.rao@xilinx.com> wrote:
> This patch fixes the below checkpatch.pl warnings.
>
> WARNING: void function return statements are not generally useful
> +       return;
> +}
>
> WARNING: void function return statements are not generally useful
> +       return;
> +}
>
> WARNING: Missing a blank line after declarations
> +               u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK;
> +               vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR,
>
Acked-by: Moritz Fischer <moritz.fischer@ettus.com>

> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>

Cheers,

Moritz