Subject: Re: [PATCH v1 01/19] mm: use put_page to free page instead of
 putback_lru_page
To: Minchan Kim <minchan@kernel.org>
References: <1457681423-26664-1-git-send-email-minchan@kernel.org>
 <1457681423-26664-2-git-send-email-minchan@kernel.org>
 <56E67AE1.60700@suse.cz> <20160315011656.GD19514@bbox>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, jlayton@poochiereds.net,
        bfields@fieldses.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        koct9i@gmail.com, aquini@redhat.com,
        virtualization@lists.linux-foundation.org,
        Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, rknize@motorola.com,
        Rik van Riel <riel@redhat.com>, Gioh Kim <gurugio@hanmail.net>,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
From: Vlastimil Babka <vbabka@suse.cz>
Message-ID: <56E85D2D.6050808@suse.cz>
Date: Tue, 15 Mar 2016 20:06:21 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160315011656.GD19514@bbox>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 741
Lines: 16

On 15.3.2016 2:16, Minchan Kim wrote:
> On Mon, Mar 14, 2016 at 09:48:33AM +0100, Vlastimil Babka wrote:
>> On 03/11/2016 08:30 AM, Minchan Kim wrote:
>>
>> Yeah, and compaction (perhaps also other migration users) has to
>> drain the lru pvec... Getting rid of this stuff is worth even by
>> itself.
> 
> Good note. Although we cannot remove lru pvec draining completely,
> at least, this patch removes a case which should drain pvec for
> returning freed page to buddy.

And this is in fact the only interesting case, right. The migrated page (at its
new target) doesn't concern compaction that much, that can go to lru pvec just
fine. But we do want the freed buddy pages to merge ASAP. I guess that's the
same for CMA, page isolation...