Subject: Re: [PATCH v6 5/8] kbuild: add fine grained build dependencies for
 exported symbols
To: Nicolas Pitre <nicolas.pitre@linaro.org>
References: <1457923336-2732-1-git-send-email-nicolas.pitre@linaro.org>
 <1457923336-2732-6-git-send-email-nicolas.pitre@linaro.org>
 <56E8718E.9010607@suse.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
From: Michal Marek <mmarek@suse.cz>
Message-ID: <56E871DA.1030909@suse.cz>
Date: Tue, 15 Mar 2016 21:34:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <56E8718E.9010607@suse.com>
Content-Type: text/plain; charset=iso-8859-2
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1688
Lines: 34

Dne 15.3.2016 v 21:33 Michal Marek napsal(a):
> Dne 14.3.2016 v 03:42 Nicolas Pitre napsal(a):
>> +# Filter out exported kernel symbol names from the preprocessor output.
>> +# See also __KSYM_DEPS__ in include/linux/export.h.
>> +# We disable the depfile generation here, so as not to overwrite the existing
>> +# depfile while fixdep is parsing it
>> +flags_nodeps = $(filter-out -Wp$(comma)-M%, $($(1)))
>> +ksym_dep_filter =                                                            \
>> +	case "$(1)" in                                                       \
>> +	cc_*_c) $(CPP) $(call flags_nodeps,c_flags) -D__KSYM_DEPS__ $< ;;    \
>> +	as_*_S) $(CPP) $(call flags_nodeps,a_flags) -D__KSYM_DEPS__ $< ;;    \
>> +	cpp_lds_S) : ;;                                                      \
>> +	*) echo "Don't know how to preprocess $(1)" >&2; false ;;            \
>> +	esac | sed -rn 's/^.*=== __KSYM_(.*) ===.*$$/KSYM_\1/p'
>> +
>> +cmd_and_fixdep =                                                             \
>> +	$(echo-cmd) $(cmd_$(1));                                             \
>> +	$(ksym_dep_filter) |                                                 \
>> +		scripts/basic/fixdep -e $(depfile) $@ '$(make-cmd)'          \
>> +			> $(dot-target).tmp;	                             \
>> +	rm -f $(depfile);                                                    \
>> +	mv -f $(dot-target).tmp $(dot-target).cmd;
>> +
>> +endif
> 
> Not sure what happened this time, but I got
> 
> drivers/md/.dm-round-robin.mod.o.cmd:5: *** unterminated call to
> function 'wildcard': missing ')'.  Stop.

Forgot to add: This was an allmodconfig build without
CONFIG_TRIM_UNUSED_SYMS.

Michal