Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752981AbcCOVUH (ORCPT ); Tue, 15 Mar 2016 17:20:07 -0400 Received: from us-mx2.synaptics.com ([192.147.44.131]:15335 "EHLO us-mx1.synaptics.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750701AbcCOVUD (ORCPT ); Tue, 15 Mar 2016 17:20:03 -0400 Subject: Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND To: Dan Carpenter , Dmitry Torokhov References: <20160315071140.GF13560@mwanda> CC: Henrik Rydberg , Christopher Heiny , , , From: Andrew Duggan Message-ID: <56E87C82.7080105@synaptics.com> Date: Tue, 15 Mar 2016 14:20:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160315071140.GF13560@mwanda> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.4.10.145] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1448 Lines: 30 On 03/15/2016 12:11 AM, Dan Carpenter wrote: > There is a typo so we have && instead of &. > > Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11') > Signed-off-by: Dan Carpenter Acked-by: Andrew Duggan > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c > index 77a5eb8..ec8a10d 100644 > --- a/drivers/input/rmi4/rmi_f11.c > +++ b/drivers/input/rmi4/rmi_f11.c > @@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev, > sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS); > sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES); > sensor_query->has_sensitivity_adjust = > - !!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ); > + !!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ); > sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE); > > sensor_query->nr_x_electrodes = > @@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev, > sensor_query->has_bending_correction = > !!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION); > sensor_query->has_large_object_suppression = > - !!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION); > + !!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION); > sensor_query->has_jitter_filter = > !!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER); > query_size++;