Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753359AbcCOVUw (ORCPT ); Tue, 15 Mar 2016 17:20:52 -0400 Received: from casper.infradead.org ([85.118.1.10]:38667 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbcCOVUu (ORCPT ); Tue, 15 Mar 2016 17:20:50 -0400 Date: Tue, 15 Mar 2016 22:20:47 +0100 From: Peter Zijlstra To: Michael Turquette Cc: rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Juri.Lelli@arm.com, steve.muckle@linaro.org, morten.rasmussen@arm.com, dietmar.eggemann@arm.com, vincent.guittot@linaro.org, Michael Turquette Subject: Re: [PATCH 4/8] cpufreq/schedutil: sysfs capacity margin tunable Message-ID: <20160315212047.GE6344@twins.programming.kicks-ass.net> References: <1457932932-28444-1-git-send-email-mturquette+renesas@baylibre.com> <1457932932-28444-5-git-send-email-mturquette+renesas@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457932932-28444-5-git-send-email-mturquette+renesas@baylibre.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 619 Lines: 12 On Sun, Mar 13, 2016 at 10:22:08PM -0700, Michael Turquette wrote: > With the addition of the global cfs capacity margin helpers in patch, > "sched/cpufreq: new cfs capacity margin helpers", we can now export > sysfs tunables from the schedutil governor. This allows privileged users > to tune the value more easily. > > The margin value is global to cfs, not per-policy. As such schedutil > does not store any state about the margin. Schedutil restores the margin > value to its default value when exiting. Yuck sysfs.. I would really rather we did not expose this per default. And certainly not in this weird form.