Message-ID: <1458078554.2375.97.camel@linux.vnet.ibm.com>
Subject: Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning
From: James Bottomley <jejb@linux.vnet.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>, qla2xxx-upstream@qlogic.com,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Nicholas Bellinger <nab@linux-iscsi.org>,
        Himanshu Madhani <himanshu.madhani@qlogic.com>,
        Quinn Tran <quinn.tran@qlogic.com>,
        Alexei Potashnik <alexei@purestorage.com>,
        Bart Van Assche <bart.vanassche@sandisk.com>,
        Swapnil Nagle <swapnil.nagle@purestorage.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Tue, 15 Mar 2016 14:49:14 -0700
In-Reply-To: <1458078051-529344-1-git-send-email-arnd@arndb.de>
References: <1458078051-529344-1-git-send-email-arnd@arndb.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1518
Lines: 36

On Tue, 2016-03-15 at 22:40 +0100, Arnd Bergmann wrote:
> The qlt_check_reserve_free_req() function produces an incorrect 
> warning when CONFIG_PROFILE_ANNOTATED_BRANCHES is set:
> 
> drivers/scsi/qla2xxx/qla_target.c: In function
> 'qlt_check_reserve_free_req':
> drivers/scsi/qla2xxx/qla_target.c:1887:3: error: 'cnt_in' may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
>    ql_dbg(ql_dbg_io, vha, 0x305a,
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>        "qla_target(%d): There is no room in the request ring: vha
> ->req->ring_index=%d, vha->req->cnt=%d, req_cnt=%d Req-out=%d Req
> -in=%d Req-Length=%d\n",
>       
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~
>        vha->vp_idx, vha->req->ring_index,
>        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>        vha->req->cnt, req_cnt, cnt, cnt_in, vha->req->length);
>        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/scsi/qla2xxx/qla_target.c:1887:3: error: 'cnt' may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
> 
> The problem is that gcc fails to track the state of the condition 
> across an annotated branch.
> 
> This slightly rearranges the code to move the second if() block
> into the first one, to avoid the warning while retaining the
> behavior of the code.

I thought our usual policy was to ask someone to fix the compiler when
it emitted a spurious warning.

James