Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933679AbcCOWpK (ORCPT ); Tue, 15 Mar 2016 18:45:10 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:33970 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752875AbcCOWpH (ORCPT ); Tue, 15 Mar 2016 18:45:07 -0400 Subject: Re: [PATCH 3/5] ARM: davinci: da8xx: add cfgchip2 to resources To: David Lechner , Sekhar Nori , Kevin Hilman , Alan Stern , Bin Liu , Petr Kulhavy References: <1458081473-8223-1-git-send-email-david@lechnology.com> <1458081473-8223-3-git-send-email-david@lechnology.com> Cc: Russell King , Greg Kroah-Hartman , Felipe Balbi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56E8906E.7070800@cogentembedded.com> Date: Wed, 16 Mar 2016 01:45:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458081473-8223-3-git-send-email-david@lechnology.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 32 Hello. On 03/16/2016 01:37 AM, David Lechner wrote: > The usb ohci driver has been change to not include mach/*, so we need > to pass the cfgchip2 address to the driver so that it can turn the usb > phy on and off. > > Signed-off-by: David Lechner > --- > arch/arm/mach-davinci/usb.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/mach-davinci/usb.c b/arch/arm/mach-davinci/usb.c > index b0a6b52..9607b0c 100644 > --- a/arch/arm/mach-davinci/usb.c > +++ b/arch/arm/mach-davinci/usb.c > @@ -148,6 +148,11 @@ static struct resource da8xx_usb11_resources[] = { > .flags = IORESOURCE_MEM, > }, > [1] = { > + .start = DA8XX_SYSCFG0_BASE + DA8XX_CFGCHIP2_REG, > + .end = DA8XX_SYSCFG0_BASE + DA8XX_CFGCHIP2_REG + 4 - 1, > + .flags = IORESOURCE_MEM, > + }, No, this register is shared b/w MUSB and OHCI. The proper thing to do is to write the PHY driver and let it control this shared register. [...] MBR, Sergei