Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964852AbcCOXNe (ORCPT ); Tue, 15 Mar 2016 19:13:34 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47165 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933855AbcCOXN3 (ORCPT ); Tue, 15 Mar 2016 19:13:29 -0400 Date: Tue, 15 Mar 2016 16:13:22 -0700 From: Stephen Boyd To: Aaro Koskinen Cc: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Andrew Morton , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drivers/firmware/broadcom/bcm47xx_nvram.c: fix incorrect __ioread32_copy Message-ID: <20160315231322.GL25972@codeaurora.org> References: <1458083178-8207-1-git-send-email-aaro.koskinen@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458083178-8207-1-git-send-email-aaro.koskinen@iki.fi> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 19 On 03/16, Aaro Koskinen wrote: > Commit 1f330c327900 ("drivers/firmware/broadcom/bcm47xx_nvram.c: use > __ioread32_copy() instead of open-coding") switched to use a generic copy > function, but failed to notice that the header pointer is updated between > the two copies, resulting in bogus data being copied in the latter one. > Fix by keeping the old header pointer. > > The patch fixes totally broken networking on WRT54GL router (both LAN > and WLAN interfaces fail to probe). > > Fixes: 1f330c327900 ("drivers/firmware/broadcom/bcm47xx_nvram.c: use __ioread32_copy() instead of open-coding") > Signed-off-by: Aaro Koskinen > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project