Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964893AbcCOXOh (ORCPT ); Tue, 15 Mar 2016 19:14:37 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:35996 "EHLO mail-io0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933703AbcCOXOe (ORCPT ); Tue, 15 Mar 2016 19:14:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <20160311223047.GZ30721@dastard> <20160312003556.GF32214@thunk.org> <20160313233049.GA30721@dastard> <56E69398.7030508@redhat.com> <20160314144603.GO29218@thunk.org> <20160315201431.GG30721@dastard> <20160315223313.GH30721@dastard> Date: Tue, 15 Mar 2016 16:14:32 -0700 X-Google-Sender-Auth: awGQhyRBf2ZzL29auPM0MGchsUM Message-ID: Subject: Re: [PATCH 2/2] block: create ioctl to discard-or-zeroout a range of blocks From: Linus Torvalds To: Dave Chinner Cc: "Theodore Ts'o" , Ric Wheeler , Andy Lutomirski , One Thousand Gnomes , Gregory Farnum , "Martin K. Petersen" , Christoph Hellwig , "Darrick J. Wong" , Jens Axboe , Andrew Morton , Linux API , Linux Kernel Mailing List , shane.seymour@hpe.com, Bruce Fields , linux-fsdevel , Jeff Layton , Eric Sandeen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 25 On Tue, Mar 15, 2016 at 4:06 PM, Linus Torvalds wrote: > > And yes, "keep the patch entirely inside google" is obviously one good > way to limit the interface. But if there are really other groups that > want to explore this, then that sounds like a pretty horrible model > too. Side note: I really don't see how your argument of "XFS has been able to do something like this for over a decade, using an even uglier trick that is hidden and not documented" is at all an argument for your position. You're saying "nobody else should be doing what I've been doing for a long time", and backing that argument up with "but I don't document it, and it's completely different because it's done at mkfs/debugfs time rather than mount-time". But now that people are talking about a filesystem-independent way of doing the same thing, now it's suddenly poisonous. Dave, I call BS on your arguments. Or maybe I misunderstood it. But it does smell very "do what I say, not what I do". Linus