Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966103AbcCOXpp (ORCPT ); Tue, 15 Mar 2016 19:45:45 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:32866 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933813AbcCOXpk (ORCPT ); Tue, 15 Mar 2016 19:45:40 -0400 Date: Tue, 15 Mar 2016 16:45:36 -0700 From: Dmitry Torokhov To: Andrew Duggan Cc: Dan Carpenter , Henrik Rydberg , Christopher Heiny , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND Message-ID: <20160315234536.GA29178@dtor-ws> References: <20160315071140.GF13560@mwanda> <56E87C82.7080105@synaptics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56E87C82.7080105@synaptics.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1577 Lines: 37 On Tue, Mar 15, 2016 at 02:20:02PM -0700, Andrew Duggan wrote: > On 03/15/2016 12:11 AM, Dan Carpenter wrote: > >There is a typo so we have && instead of &. > > > >Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11') > >Signed-off-by: Dan Carpenter > > Acked-by: Andrew Duggan Applied, thank you. > > >diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c > >index 77a5eb8..ec8a10d 100644 > >--- a/drivers/input/rmi4/rmi_f11.c > >+++ b/drivers/input/rmi4/rmi_f11.c > >@@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev, > > sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS); > > sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES); > > sensor_query->has_sensitivity_adjust = > >- !!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ); > >+ !!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ); > > sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE); > > sensor_query->nr_x_electrodes = > >@@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev, > > sensor_query->has_bending_correction = > > !!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION); > > sensor_query->has_large_object_suppression = > >- !!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION); > >+ !!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION); > > sensor_query->has_jitter_filter = > > !!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER); > > query_size++; > -- Dmitry