Message-ID: <8760wnfe3r.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 0/2] pinctrl: sh-pfc: tidyup IPSR/MOD_SEL/GPSR settings order
User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0
CC: Magnus <magnus.damm@gmail.com>, Simon <horms@verge.net.au>,
        <linux-renesas-soc@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
Date: Wed, 16 Mar 2016 00:46:47 +0000
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2016 00:46:47.1752 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB1019
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 802
Lines: 32


Hi Geert, Laurent

Gen2 / Gen3 next datasheet will has below note.
Our current PFC settings order is
	MOD_SEL -> GPSR -> IPSR
But, this fixes it to
	MOD_SEL -> IPSR -> GPSR

------------
IPSRx and MOD_SELx registers shall be set before setting GPSRx
registers in case that they need to be configured.
MOD_SELx registers can be set either earlier or later than setting
IPSRx registers.
------------

1) patch make it easy to check
2) patch fixes above

Kuninori Morimoto (2):
      1) pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug
      2) pinctrl: sh-pfc: IPSRx and MOD_SELx should be set before GPSRx

 drivers/pinctrl/sh-pfc/core.c   |  3 ++-
 drivers/pinctrl/sh-pfc/sh_pfc.h | 11 +++++++----
 2 files changed, 9 insertions(+), 5 deletions(-)


Best regards
---
Kuninori Morimoto