Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934365AbcCPDJi (ORCPT ); Tue, 15 Mar 2016 23:09:38 -0400 Received: from mga03.intel.com ([134.134.136.65]:7312 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753496AbcCPDJf (ORCPT ); Tue, 15 Mar 2016 23:09:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,342,1455004800"; d="scan'208";a="934771828" Date: Wed, 16 Mar 2016 08:43:51 +0530 From: Vinod Koul To: Kedareswara rao Appana Cc: dan.j.williams@intel.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, appanad@xilinx.com, moritz.fischer@ettus.com, laurent.pinchart@ideasonboard.com, luis@debethencourt.com, anirudh@xilinx.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] dmaengine: xilinx_vdma: Add quirks support to differentiate differnet IP cores Message-ID: <20160316031350.GN13211@localhost> References: <1458062592-27981-1-git-send-email-appanad@xilinx.com> <1458062592-27981-3-git-send-email-appanad@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458062592-27981-3-git-send-email-appanad@xilinx.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 329 Lines: 11 On Tue, Mar 15, 2016 at 10:53:07PM +0530, Kedareswara rao Appana wrote: > This patch adds quirks support in the driver to differentiate differnet IP cores. Wouldn't it help to explain why quirks are needed for these cores in changelog? Also limit your changelogs properly. Am sure checkpatch would have warned you! -- ~Vinod