Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934379AbcCPDR7 (ORCPT ); Tue, 15 Mar 2016 23:17:59 -0400 Received: from mga03.intel.com ([134.134.136.65]:56522 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934187AbcCPDR5 (ORCPT ); Tue, 15 Mar 2016 23:17:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,342,1455004800"; d="asc'?scan'208";a="934776075" Date: Wed, 16 Mar 2016 08:52:13 +0530 From: Vinod Koul To: Maxime Ripard Cc: Boris Brezillon , Dan Williams , dmaengine@vger.kernel.org, Chen-Yu Tsai , linux-sunxi@googlegroups.com, Emilio =?iso-8859-1?Q?L=F3pez?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma: sun4i: expose block size and wait cycle configuration to DMA users Message-ID: <20160316032213.GP13211@localhost> References: <20160307160857.577bb04d@bbrezillon> <20160307203024.GD8418@lukather> <20160308025547.GI11154@localhost> <20160309120627.67612b1d@bbrezillon> <20160311062607.GP11154@localhost> <20160311104552.23e06a16@bbrezillon> <20160311100902.GY11154@localhost> <20160311105549.GZ8418@lukather> <20160311111825.GC11154@localhost> <20160314114641.GC30977@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5gxpn/Q6ypwruk0T" Content-Disposition: inline In-Reply-To: <20160314114641.GC30977@lukather> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2245 Lines: 61 --5gxpn/Q6ypwruk0T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 14, 2016 at 12:46:41PM +0100, Maxime Ripard wrote: > On Fri, Mar 11, 2016 at 04:48:26PM +0530, Vinod Koul wrote: > > > > But this nees to be property for clients and not driver. Client can= then > > > > program these > > >=20 > > > Yes, totally. The question here is how the clients give that > > > information to the driver. > >=20 > > For this part am not worried. If we can generalize this then we add to > > dma_slave_config. Otherwise an exported symbol from driver should be fi= ne. >=20 > It's actually what we would like to avoid. >=20 > We have two potential provider driver that would need such an > interface, and we have customer drivers that would be able to use any > of these two, depending on which SoCs we're talking about. >=20 > Maintaining some logic in each and every driver in that case to know > which one of this symbol is to be called seems counterproductive and > painful. You didn't specify which one you want to avoid, and my guess is latter choice and not former :) As I said, if it's something we can use in few examples and describe generically I do not mind adding to dma_slave_config --=20 ~Vinod --5gxpn/Q6ypwruk0T Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW6NFlAAoJEHwUBw8lI4NH7O4P/0pSDpMPuy6wToJjEIF5owI1 GGXFS+hDCyP/EOiYp+TtugyJvUZuVk4R9Hpx79qv5PmnAdzvId8jSNG+BTdmTX0k 2vrxRO9TWE0nyb7UdmeuwBd+3MUaZpWHtH4FMGkpREI0f4uCV30uU2n++BKsg4/Z WVghtbrUHtpWgj1kPGQLVvm8CugzVZAEb4dVFJsQR722RtMoutXB+2wiyzvQpTeh oHWvL2V/+EQF7OGCFBeAuoDnMqToyFJNissFwvJWPndJqqpGrVj0wl7b2yTodtwA 1WYB4qhhur+czn9ExkmN3vdrHgGErneGbNRhANZx9rsgztQNhFd+B3wL4z9P5FOu r1pxpIgzKKkVUPf7pCkNWSsE98joCmGMdIsYB+9d0P7cAQHOboRX8vR237TtdF67 PLnjaN2aNoYbCjicD1X0j7siQxFPESLGwyoKIlOPsnqJ3X1mECd0AAek17PonFwk jC1OHdjrLbkTxstlyDlBZt032gifWxydJlVE39gYOttfkzEABoXJrJp7wGGFnT2l JUT24A6dJxLvoITChb6k2/KqM1QS8T6vMawG4M3vIjk2YoP/i9E5Ei47a0jV7uLD msLnZqAP6dP4QHIDZqOqy6aAzfhFQ5aWTLKdvy77SUG+Q3zlnSs5gXcOXtCA/W53 ugLNpJ0C/ag0BiNoz/Wi =qagl -----END PGP SIGNATURE----- --5gxpn/Q6ypwruk0T--