Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S263356AbTCNPZh>; Fri, 14 Mar 2003 10:25:37 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S263348AbTCNPZh>; Fri, 14 Mar 2003 10:25:37 -0500
Received: from air-2.osdl.org ([65.172.181.6]:37021 "EHLO mail.osdl.org")
	by vger.kernel.org with ESMTP id <S263347AbTCNPZe>;
	Fri, 14 Mar 2003 10:25:34 -0500
Subject: Re: Problem with aacraid driver in 2.5.63-bk-latest
From: Mark Haverkamp <markh@osdl.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Doug Ledford <dledford@redhat.com>, dougg@torque.net,
       Christoffer Hall-Frederiksen <hall@jiffies.dk>,
       linux-scsi@vger.kernel.org,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       linux aacraid devel <linux-aacraid-devel@dell.com>
In-Reply-To: <1047653879.29544.9.camel@irongate.swansea.linux.org.uk>
References: <20030228133037.GB7473@jiffies.dk>
	 <1047510381.12193.28.camel@markh1.pdx.osdl.net>
	 <1047514681.23725.35.camel@irongate.swansea.linux.org.uk>
	 <3E6FC8D6.7090005@torque.net>
	 <1047517604.23902.39.camel@irongate.swansea.linux.org.uk>
	 <1047570132.30105.7.camel@markh1.pdx.osdl.net>
	 <3E711194.9010505@redhat.com>
	 <1047597729.30103.386.camel@markh1.pdx.osdl.net>
	 <3E71134F.5060404@redhat.com>
	 <1047653879.29544.9.camel@irongate.swansea.linux.org.uk>
Content-Type: text/plain
Organization: 
Message-Id: <1047656071.7556.12.camel@markh1.pdx.osdl.net>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.2 
Date: 14 Mar 2003 07:34:32 -0800
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1467
Lines: 34

On Fri, 2003-03-14 at 06:57, Alan Cox wrote:
> On Thu, 2003-03-13 at 23:25, Doug Ledford wrote:
> > Mark Haverkamp wrote:
> > > Then it sounds like the aacraid driver could set cmd_per_lun to a small
> > > number like one since the real queue depth will be set later in
> > > aac_slave_configure.
> > 
> > Yes.  And since the driver doesn't support anything other than drives to 
> > my knowledge, 1 would be appropriate.
> 
> It supports both disks and non disk devices. Disks are mapped onto bus 0
> and are driven via firmware smarts as logical devices, non disks are bus 1
> and there it behaves mostly like a scsi controller


Is aac_slave_configure only called for disk devices?  If its called for
all scsi devices, then the queue depth will always be set to something a
lot less than 512.  I did some searching through the scsi code and I see
only two places that cmd_per_lun is used. It is used to set the queue
depth in scsi_track_queue_full and scsi_alloc_sdev. So it seems that, if
aac_slave_configure gets called for all scsi devices, that setting
cmd_per_lun in the aacraid scsi host template to 1 would be OK.  Does
that make sense or did I miss something?

Thanks,
Mark.
-- 
Mark Haverkamp <markh@osdl.org>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/