Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755253AbcCPF7m (ORCPT ); Wed, 16 Mar 2016 01:59:42 -0400 Received: from mga14.intel.com ([192.55.52.115]:15071 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754175AbcCPF7k convert rfc822-to-8bit (ORCPT ); Wed, 16 Mar 2016 01:59:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,343,1455004800"; d="scan'208";a="925068795" From: "Chen, Yu C" To: Matt Fleming CC: "linux-acpi@vger.kernel.org" , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Len Brown , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "Zhang, Rui" , "linux-efi@vger.kernel.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Ard Biesheuvel , Mark Salter Subject: RE: [PATCH][RFC,v4] ACPI / PM: Introduce efi poweroff for HW-full platforms without _S5 Thread-Topic: [PATCH][RFC,v4] ACPI / PM: Introduce efi poweroff for HW-full platforms without _S5 Thread-Index: AQHRe3RlqjzIKmiap0+aItZGSTsxWp9T3+0AgACOePCABGzrgIACuHEQ Date: Wed, 16 Mar 2016 05:59:29 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE640286D5713@shsmsx102.ccr.corp.intel.com> References: <1457687133-3730-1-git-send-email-yu.c.chen@intel.com> <20160311155546.GJ15775@codeblueprint.co.uk> <36DF59CE26D8EE47B0655C516E9CE640286D442A@shsmsx102.ccr.corp.intel.com> <20160314200033.GG2619@codeblueprint.co.uk> In-Reply-To: <20160314200033.GG2619@codeblueprint.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjQ0OGM3ZTktZjRkZi00NzdhLTg4MjUtOGIwMDJhNGUxNWY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlB6WU9yZ1d2a3R3UHk3eUt2VkgwR3V1RzROeVR3NDFpY1wvZUxweVpPVFpFPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 37 Hi Matt, > -----Original Message----- > From: Matt Fleming [mailto:matt@codeblueprint.co.uk] > Sent: Tuesday, March 15, 2016 4:01 AM > To: Chen, Yu C > Cc: linux-acpi@vger.kernel.org; linux-pm@vger.kernel.org; Rafael J. Wysocki; > Len Brown; Thomas Gleixner; Ingo Molnar; H. Peter Anvin; Zhang, Rui; linux- > efi@vger.kernel.org; x86@kernel.org; linux-kernel@vger.kernel.org; Ard > Biesheuvel; Mark Salter > Subject: Re: [PATCH][RFC,v4] ACPI / PM: Introduce efi poweroff for HW-full > platforms without _S5 > > On Fri, 11 Mar, at 04:33:46PM, Chen, Yu C wrote: > > > > There is a future Base-IA platform, we are planning to skip > > implementing the SLP_TYP register and the S5 object. (already there > > will be no S3 and no S4) > > Cool. This is really valuable information that should go into the commit > message. > > Because if this is the rationale for the change, I don't see why we'd need to > provide the default stuff. Instead we should just enforce EFI reboot, and > only add the pm_poweroff_default hook if there is an explicit user in the > future, IMO. Do you mean the patch v3 make sense https://patchwork.kernel.org/patch/8514751/ and we should use efi power off as our first choice, if there is no _S5 available(no acpi_power_off), even there is a customized poweroff(driver provided, eg)? Meanwhile, the legacy platforms will not be affected because there is no path to overwrite pm_power_off to efi power off. thanks, yu