Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932886AbcCPHL5 (ORCPT ); Wed, 16 Mar 2016 03:11:57 -0400 Received: from mail-oi0-f47.google.com ([209.85.218.47]:32941 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbcCPHL4 (ORCPT ); Wed, 16 Mar 2016 03:11:56 -0400 Subject: Re: [PATCH] Remove v850 from linux/elf-em.h To: David Daney References: <56E87A63.8020703@landley.net> <56E89928.1010008@gmail.com> Cc: Andrew Morton , "linux-kernel@vger.kernel.org" , Greg Ungerer From: Rob Landley Message-ID: <56E90733.4010805@landley.net> Date: Wed, 16 Mar 2016 02:11:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56E89928.1010008@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1777 Lines: 46 On 03/15/2016 06:22 PM, David Daney wrote: > On 03/15/2016 02:10 PM, Rob Landley wrote: >> From: Rob Landley >> >> The v850 port was removed by commits f606ddf42fd4 and 07a887d399b8 in >> 2008. >> These #defines are not used in the current kernel. >> >> Signed-off-by: Rob Landley >> --- >> include/uapi/linux/elf-em.h | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/include/uapi/linux/elf-em.h b/include/uapi/linux/elf-em.h >> index b56dfcf..c3fdfe7 100644 >> --- a/include/uapi/linux/elf-em.h >> +++ b/include/uapi/linux/elf-em.h >> @@ -30,7 +30,6 @@ >> #define EM_X86_64 62 /* AMD x86-64 */ >> #define EM_S390 22 /* IBM S/390 */ >> #define EM_CRIS 76 /* Axis Communications 32-bit embedded >> processor */ >> -#define EM_V850 87 /* NEC v850 */ > > Can you do this to userspace visible files? Commit 6f6f467eaaa0 did and nobody seemed to mind? > I thought only additions and obvious corrections were allowed. Removing > symbols could cause build breakage for something. There's a /usr/include/elf.h in glibc with 3 times as many EM_BLAH symbols as this one defines. Something that cares about identifying architectures Linux doesn't actually support would presumably use that header instead of this one. This is the only architecture included in this file that isn't currently supported by Linux (except the mips symbols with the comment about them not being used, which have been there since the first version of the file). I found this while auditing toybox's "file" command. (We just copied the constant values into our own table, but when making the table I was checking which values the actual Linux ELF loaders in the various arch directories would bind to.) Rob