Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934508AbcCPHkx (ORCPT ); Wed, 16 Mar 2016 03:40:53 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:64967 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933642AbcCPHkv (ORCPT ); Wed, 16 Mar 2016 03:40:51 -0400 X-AuditID: cbfec7f4-f79026d00000418a-0c-56e90e003841 Message-id: <56E90DFF.6090603@samsung.com> Date: Wed, 16 Mar 2016 08:40:47 +0100 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Linus Torvalds Cc: Stephen Rothwell , Linux Kernel Mailing List , Linux LED Subsystem , amitoj1606@gmail.com, ao2@ao2.it, drivshin@allworx.com, Geert Uytterhoeven , hkallweit1@gmail.com, stefan.wahren@i2se.com, Wei Yongjun Subject: Re: [GIT PULL] LED subsystem updates for 4.6 References: <1457951097-27079-1-git-send-email-j.anaszewski@samsung.com> <20160315103613.3eb6347e@canb.auug.org.au> <56E7BEE8.2000004@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42I5/e/4ZV0GvpdhBs0LdCwe/VrEZtEzs4HR YtnLU2wWc2dPYrRY9H4Gq8XlXXPYLLa+WcdosXXvVXaLTStusFk86nvLbrFzXSe7A7dHQ/dT No/WOzvYPBpv3GDzmHhW12PnrLvsHltvmXqcmPGbxWPpvaOMHp83yQVwRnHZpKTmZJalFunb JXBlPDm6hbHgP2fFlh23WBoYP7J3MXJySAiYSMzfeJsFwhaTuHBvPVsXIxeHkMBSRold7cfZ IZxnjBKbZ19iBKniFdCSOP3qKCuIzSKgKnG/9RsziM0mYCjx88VrJhBbVCBC4s/pfawQ9YIS PybfA9sgImAk8fnFFVaQocwCj5gkjq56BTSUg0NYwFRi4i4hiGW3GSV2r10NNohTIFhiSscO sGZmATOJRy3rmCFseYnNa94yT2AUmIVkxywkZbOQlC1gZF7FKJpamlxQnJSea6hXnJhbXJqX rpecn7uJERI1X3YwLj5mdYhRgINRiYd3R9KLMCHWxLLiytxDjBIczEoivEcZXoYJ8aYkVlal FuXHF5XmpBYfYpTmYFES5527632IkEB6YklqdmpqQWoRTJaJg1OqgbH8rZy69Nx1f5efTvvZ rfW/qfYSw9s11V1rQ43VjdVMkxj8vrrny53LNuNVNmcQOqOtuuXqnzmMaSfrVk34Xm7LHr80 3+55ap2oRO6JPsawiZatDDq7/zm+vG34T9ytgCdDWUFXu/hSXKeN2hVf/n1L9t+Y4r1p6pLF RsWinIIL7B9FiOZxKrEUZyQaajEXFScCAKoWWUGWAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1247 Lines: 32 On 03/16/2016 06:04 AM, Linus Torvalds wrote: > On Tue, Mar 15, 2016 at 12:51 AM, Jacek Anaszewski > wrote: >> >> I just wanted to make sure that no unexpected problem has occurred >> after rebasing onto 4.5 release. Is it in some way more advantageous to >> base a pull request on rc7, than on a final release? > > I'd rather see the pull request based on whatever it has been tested > on, and just keep it that way. > > Any rebasing will inevitably mean that you are basically throwing all > previous testing out the window (or at least make it dubious). > > Rebasing also makes it much harder to see the history (for example, > compare it against previous linux-next trees), so the rule really > should be that you should never rebase unless you have a major reason > to do so. > > So for example, if you actually find a problem, and you notice that > that problem comes not from your own changes, but from the base you > picked - *then* you'd want to rebase to a more stable base. But a > rebase "just because" is not a good idea. > > I'll pull it, since it looks fairly harmless, but basically please > don't do that again. Thanks for the explanation. I'll proceed accordingly. -- Best regards, Jacek Anaszewski