Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934895AbcCPHlo (ORCPT ); Wed, 16 Mar 2016 03:41:44 -0400 Received: from conssluserg004.nifty.com ([202.248.44.42]:19252 "EHLO conssluserg004-v.nifty.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933603AbcCPHll (ORCPT ); Wed, 16 Mar 2016 03:41:41 -0400 X-Nifty-SrcIP: [209.85.161.169] MIME-Version: 1.0 In-Reply-To: <20160314215217.7fa20e0c85bfda75dc11b70c@gmail.com> References: <20160307000208.1bec3e7dc874489d1b4fcbb4@gmail.com> <20160307000427.c82f18670568e1e656fc9532@gmail.com> <20160314215217.7fa20e0c85bfda75dc11b70c@gmail.com> Date: Wed, 16 Mar 2016 16:41:36 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 2/5] GCC plugin infrastructure From: Masahiro Yamada To: Emese Revfy Cc: Linux Kbuild mailing list , pageexec@freemail.hu, spender@grsecurity.net, kernel-hardening@lists.openwall.com, Michal Marek , Kees Cook , Rasmus Villemoes , fengguang.wu@intel.com, Dmitry Vyukov , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1625 Lines: 48 Hi Emese, 2016-03-15 5:52 GMT+09:00 Emese Revfy : > On Fri, 11 Mar 2016 15:25:19 +0900 > Masahiro Yamada wrote: > >> Maybe scripts/gcc-plugins/ is better than tools/gcc ? >> >> In the directory "scripts/", we have several tools used during >> building the kernel image. >> We have some optional programs in the directory "tools/", which are not used >> for building the kernel image itself. >> >> Please correct me if I am wrong. > > I think scripts isn't the right place because there are tools there which don't get used > during the building of vmlinux (e.g., coccinelle, checkpatch). No, this is not what I meant. What I want to say is: All the host tools used for building vmlinux should be located in the directory "scripts/", but the directory may also other host tools that are not used for building vmlinux (such as checkpatch). > The scripts name also doesn't describe gcc plugins well. With my suggestion "scripts/gcc-plugins/", the sub-directory name describes it very well. > Plugins take part in the image building process > in a different way than these tools and scripts do. > Since there doesn't seen to be a good place for compiler plugins, maybe we should create a new toplevel directory > called "build". Compiler plugins and other existing build tools could live there. What do you think? In my understanding, they are plug-in'ed into the cross-compiler that compiles vmlinux. If so, GCC plugins should be happy in "scripts/" because Kbuild descends into "scripts/" before building any objects for vmlinux. -- Best Regards Masahiro Yamada