Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966175AbcCPIJQ (ORCPT ); Wed, 16 Mar 2016 04:09:16 -0400 Received: from mail.kernel.org ([198.145.29.136]:59583 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965137AbcCPIJG (ORCPT ); Wed, 16 Mar 2016 04:09:06 -0400 From: lizf@kernel.org To: stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, NeilBrown , Zefan Li Subject: [PATCH 3.4 035/107] md: flush ->event_work before stopping array. Date: Wed, 16 Mar 2016 16:05:29 +0800 Message-Id: <1458115601-5762-35-git-send-email-lizf@kernel.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1458115541-5712-1-git-send-email-lizf@kernel.org> References: <1458115541-5712-1-git-send-email-lizf@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1173 Lines: 39 From: NeilBrown 3.4.111-rc1 review patch. If anyone has any objections, please let me know. ------------------ commit ee5d004fd0591536a061451eba2b187092e9127c upstream. The 'event_work' worker used by dm-raid may still be running when the array is stopped. This can result in an oops. So flush the workqueue on which it is run after detaching and before destroying the device. Reported-by: Heinz Mauelshagen Signed-off-by: NeilBrown Fixes: 9d09e663d550 ("dm: raid456 basic support") [lizf: Backported to 3.4: adjust context] Signed-off-by: Zefan Li --- drivers/md/md.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/md/md.c b/drivers/md/md.c index 25f0cb5..a875348 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -5127,6 +5127,8 @@ static void __md_stop(struct mddev *mddev) if (mddev->pers->sync_request && mddev->to_remove == NULL) mddev->to_remove = &md_redundancy_group; module_put(mddev->pers->owner); + /* Ensure ->event_work is done */ + flush_workqueue(md_misc_wq); mddev->pers = NULL; clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery); } -- 1.9.1