Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966295AbcCPI1a (ORCPT ); Wed, 16 Mar 2016 04:27:30 -0400 Received: from mail-ig0-f170.google.com ([209.85.213.170]:34717 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965043AbcCPI1Y (ORCPT ); Wed, 16 Mar 2016 04:27:24 -0400 MIME-Version: 1.0 In-Reply-To: <874mc7fe29.wl%kuninori.morimoto.gx@renesas.com> References: <8760wnfe3r.wl%kuninori.morimoto.gx@renesas.com> <874mc7fe29.wl%kuninori.morimoto.gx@renesas.com> Date: Wed, 16 Mar 2016 09:27:22 +0100 X-Google-Sender-Auth: PS_TyZqcG4ZxJsh8Yvx2X_ZJQmA Message-ID: Subject: Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug From: Geert Uytterhoeven To: Kuninori Morimoto Cc: Laurent Pinchart , Geert Uytterhoeven , Linus Walleij , Magnus , Simon , linux-renesas-soc@vger.kernel.org, "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 32 Hi Morimoto-san, On Wed, Mar 16, 2016 at 1:47 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug. > Of course we can get it from indicated register address, but it > is not convenient. This patch enables to indicate these. > > Signed-off-by: Kuninori Morimoto > --- a/drivers/pinctrl/sh-pfc/sh_pfc.h > +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h > @@ -94,6 +94,7 @@ struct pinmux_func { > }; > > struct pinmux_cfg_reg { > + const char *name; Have you looked at the size increase, esp. for multi-platform kernels? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds