Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966094AbcCPIkA (ORCPT ); Wed, 16 Mar 2016 04:40:00 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35865 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934448AbcCPIjz (ORCPT ); Wed, 16 Mar 2016 04:39:55 -0400 Date: Wed, 16 Mar 2016 08:39:50 +0000 From: Lee Jones To: Jonathan Cameron Cc: Sudip Mukherjee , Markus Pargmann , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH] iio: adc: imx25-gcq: fix do_div Message-ID: <20160316083950.GU13692@x1> References: <1457009513-7069-1-git-send-email-sudipm.mukherjee@gmail.com> <56DB28BF.9070508@kernel.org> <8010548.jDMIC4yOG6@adelgunde> <20160307110632.GA10337@sudip-pc> <56E3F8D3.3020707@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56E3F8D3.3020707@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1442 Lines: 40 On Sat, 12 Mar 2016, Jonathan Cameron wrote: > On 07/03/16 11:06, Sudip Mukherjee wrote: > > On Mon, Mar 07, 2016 at 10:01:34AM +0100, Markus Pargmann wrote: > >> Hi, > >> > >> On Saturday 05 March 2016 18:43:11 Jonathan Cameron wrote: > >>> On 03/03/16 12:51, Sudip Mukherjee wrote: > >>>> We are getting build failure with tilepro allmodconfig with the error: > >>>> > >>>> drivers/iio/adc/fsl-imx25-gcq.c:236:4: note: in expansion of macro 'do_div' > >>>> do_div(priv->channel_vref_mv[reg], 1000); > >>>> ^ > >>>> > >>>> include/asm-generic/div64.h:198:17: note: expected 'uint64_t * > >>>> {aka long long unsigned int *}' but argument is of type 'u32 * > >>>> {aka unsigned int *}' > >>>> > >>>> Create a temporary variable of type u64 and use that in do_div. > >>>> > >>>> Signed-off-by: Sudip Mukherjee > >>> Markus, can you take a quick look at this. > >> > >> Thanks. I think this was already fixed by Arnd. > >> "iio: adc/imx25-gcq: move incorrect do_div" > > > > It should. But I still have the same build failure with next-20160307 > > and not only tilepro, even m32r is also having the same build failure. > > > Lee, did you pick the original fix from Arnd up? > > I can take this after the merge window if not. Yes, it's in my tree. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog