Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965937AbcCPIsB (ORCPT ); Wed, 16 Mar 2016 04:48:01 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:55705 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964829AbcCPIr6 (ORCPT ); Wed, 16 Mar 2016 04:47:58 -0400 Subject: Re: [PATCH v2 4/5] mmc: davinci: don't use dma platform resources To: David Lechner , References: <56E6BF7E.7020401@ti.com> <1457996081-21975-1-git-send-email-david@lechnology.com> <1457996081-21975-5-git-send-email-david@lechnology.com> <56E7CDAC.1090907@ti.com> <56E842EE.7030301@lechnology.com> CC: , , , , From: Peter Ujfalusi Message-ID: <56E91D72.4030606@ti.com> Date: Wed, 16 Mar 2016 10:46:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <56E842EE.7030301@lechnology.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 901 Lines: 24 On 03/15/16 19:14, David Lechner wrote: > On 03/15/2016 03:54 AM, Peter Ujfalusi wrote: >> On 03/15/16 00:54, David Lechner wrote: >>> >>> host->dma_tx = >>> - dma_request_slave_channel_compat(mask, edma_filter_fn, >>> - &host->txdma, mmc_dev(host->mmc), "tx"); >>> + dma_request_slave_channel(mmc_dev(host->mmc), "tx"); >> >> you would need to use dma_request_chan() to be able to rely on the legacy >> channel mapping. >> I have staged commits for converting all daVinci and OMAP drivers, I'll attach >> the patch I have for davinci-mmc for reference. >> When we convert to use the dma_request_chan() we can handle deferred probing >> also... >> > > OK. So I should redo this patch on top of the patch you attached? Or replace your patch with mine in your series. In my patch I forgot to remove the 'u32 rxdma, txdma;' from struct mmc_davinci_host... -- P?ter