Subject: Re: [PATCH v2 all 12/14] memory: omap-gpmc: use
 of_platform_default_populate() to populate default bus
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <1458113743-15131-1-git-send-email-wangkefeng.wang@huawei.com>
 <1458113743-15131-13-git-send-email-wangkefeng.wang@huawei.com>
CC: <arnd@arndb.de>, <shawnguo@kernel.org>, <catalin.marinas@arm.com>,
        <linux@arm.linux.org.uk>, <robh+dt@kernel.org>,
        <grant.likely@linaro.org>, <olof@lixom.net>,
        <yamada.masahiro@socionext.com>, <guohanjun@huawei.com>,
        Tony Lindgren <tony@atomide.com>
From: Roger Quadros <rogerq@ti.com>
Message-ID: <56E9379B.1050103@ti.com>
Date: Wed, 16 Mar 2016 12:38:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1458113743-15131-13-git-send-email-wangkefeng.wang@huawei.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1047
Lines: 33

On 16/03/16 09:35, Kefeng Wang wrote:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
> 
> Cc: Roger Quadros <rogerq@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Acked-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger

> ---
>  drivers/memory/omap-gpmc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index 6515dfc..455fc73 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2016,8 +2016,7 @@ no_timings:
>  	/* is child a common bus? */
>  	if (of_match_node(of_default_bus_match_table, child))
>  		/* create children and other common bus children */
> -		if (of_platform_populate(child, of_default_bus_match_table,
> -					 NULL, &pdev->dev))
> +		if (of_platform_default_populate(child, NULL, &pdev->dev))
>  			goto err_child_fail;
>  
>  	return 0;
>