Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966636AbcCPLet (ORCPT ); Wed, 16 Mar 2016 07:34:49 -0400 Received: from mail-lf0-f50.google.com ([209.85.215.50]:33827 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754275AbcCPLep (ORCPT ); Wed, 16 Mar 2016 07:34:45 -0400 Subject: Re: [PATCH 3/5] ARM: davinci: da8xx: add cfgchip2 to resources To: David Lechner , Sekhar Nori , Kevin Hilman , Alan Stern , Bin Liu , Petr Kulhavy References: <1458081473-8223-1-git-send-email-david@lechnology.com> <1458081473-8223-3-git-send-email-david@lechnology.com> <56E8906E.7070800@cogentembedded.com> <56E8D720.7000508@lechnology.com> Cc: Russell King , Greg Kroah-Hartman , Felipe Balbi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org From: Sergei Shtylyov Message-ID: <56E944D1.9000907@cogentembedded.com> Date: Wed, 16 Mar 2016 14:34:41 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E8D720.7000508@lechnology.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 626 Lines: 16 Hello. On 3/16/2016 6:46 AM, David Lechner wrote: >> No, this register is shared b/w MUSB and OHCI. The proper thing to >> do is to write the PHY driver and let it control this shared register. > OK. I've started working on this. I am looking at using struct usb_phy, > however, enum usb_phy_type only has USB_PHY_TYPE_UNDEFINED, USB_PHY_TYPE_USB2, > and USB_PHY_TYPE_USB3. Would it be acceptable to use USB_PHY_TYPE_UNDEFINED > for the ohci since it is USB 1.1? Or perhaps I should use the more generic > struct phy for that one? No new USB PHY drivers accepted, look at drivers/phy/ instead please. MBR, Sergei