Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935079AbcCPLiS (ORCPT ); Wed, 16 Mar 2016 07:38:18 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:34996 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935078AbcCPLiM (ORCPT ); Wed, 16 Mar 2016 07:38:12 -0400 MIME-Version: 1.0 In-Reply-To: <1457714145-6958-1-git-send-email-shawn.lin@rock-chips.com> References: <1457714145-6958-1-git-send-email-shawn.lin@rock-chips.com> Date: Wed, 16 Mar 2016 12:38:10 +0100 Message-ID: Subject: Re: [PATCH] mmc: core: remove redundant memset of mmc_decode_cid From: Ulf Hansson To: Shawn Lin Cc: linux-mmc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 38 On 11 March 2016 at 17:35, Shawn Lin wrote: > When initializing sd or sdio card, we get struct mmc_card > from mmc_alloc_card which allocates it by kzalloc. So we don't > need another memset while decoding cid. > > Signed-off-by: Shawn Lin Thanks, applied for next! Kind regards Uffe > --- > > drivers/mmc/core/sd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c > index bb39a29..b95bd24 100644 > --- a/drivers/mmc/core/sd.c > +++ b/drivers/mmc/core/sd.c > @@ -74,8 +74,6 @@ void mmc_decode_cid(struct mmc_card *card) > { > u32 *resp = card->raw_cid; > > - memset(&card->cid, 0, sizeof(struct mmc_cid)); > - > /* > * SD doesn't currently have a version field so we will > * have to assume we can parse this. > -- > 2.3.7 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html