Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935121AbcCPLi0 (ORCPT ); Wed, 16 Mar 2016 07:38:26 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36735 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935078AbcCPLiV (ORCPT ); Wed, 16 Mar 2016 07:38:21 -0400 MIME-Version: 1.0 In-Reply-To: <1457930493-19021-1-git-send-email-shawn.lin@rock-chips.com> References: <1457930493-19021-1-git-send-email-shawn.lin@rock-chips.com> Date: Wed, 16 Mar 2016 12:38:15 +0100 Message-ID: Subject: Re: [PATCH] mmc: core: remove redundant memset of sdio_read_cccr From: Ulf Hansson To: Shawn Lin Cc: linux-mmc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 35 On 14 March 2016 at 05:41, Shawn Lin wrote: > When initializing sdio card, we get struct mmc_card > from mmc_alloc_card which allocates it by kzalloc. So we > don't need another memset while reading cccr. > > Signed-off-by: Shawn Lin Thanks, applied for next! Kind regards Uffe > --- > > drivers/mmc/core/sdio.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c > index 467b3cf..bd44ba8 100644 > --- a/drivers/mmc/core/sdio.c > +++ b/drivers/mmc/core/sdio.c > @@ -106,8 +106,6 @@ static int sdio_read_cccr(struct mmc_card *card, u32 ocr) > unsigned char data; > unsigned char speed; > > - memset(&card->cccr, 0, sizeof(struct sdio_cccr)); > - > ret = mmc_io_rw_direct(card, 0, 0, SDIO_CCCR_CCCR, 0, &data); > if (ret) > goto out; > -- > 2.3.7 > >