Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934605AbcCPMAP (ORCPT ); Wed, 16 Mar 2016 08:00:15 -0400 Received: from mail-oi0-f51.google.com ([209.85.218.51]:36750 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933983AbcCPMAK (ORCPT ); Wed, 16 Mar 2016 08:00:10 -0400 MIME-Version: 1.0 In-Reply-To: <1457726584.587.5.camel@suse.com> References: <1457089198-27171-1-git-send-email-mbrugger@suse.com> <1457726584.587.5.camel@suse.com> Date: Wed, 16 Mar 2016 13:00:09 +0100 Message-ID: Subject: Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller From: Linus Walleij To: Matthias Brugger Cc: Alexandre Courbot , Quan Nguyen , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 38 On Fri, Mar 11, 2016 at 9:03 PM, Matthias Brugger wrote: > On Fri, 2016-03-11 at 23:01 +0700, Linus Walleij wrote: >> On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger >> wrote: >> >> > The standby GPIO controller can be used as a interrupt controller. >> > Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get >> > a compilation error: >> > >> > drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe': >> > drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has >> > no member named 'irqdomain' >> > priv->gc.irqdomain = priv->irq_domain; >> > ^ >> > scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio >> > -xgene-sb.o' failed >> > make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1 >> > >> > Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as >> > interrupt controller" >> > Signed-off-by: Matthias Brugger >> >> Quan's patch exporting the symbols has been merged by tglx >> so dropping this. >> > > Thanks for the info. > > Actually this is v1 [1] of the patch, which just addresses the > GPIOLIB_IRQCHIP problem? > With Quan's patch this should still be present. Ah sorry I screwed up here and confused the patches. Patch applied. Yours, Linus Walleij