Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966521AbcCPMU3 (ORCPT ); Wed, 16 Mar 2016 08:20:29 -0400 Received: from ducie-dc1.codethink.co.uk ([185.25.241.215]:48319 "EHLO ducie-dc1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965866AbcCPMUY (ORCPT ); Wed, 16 Mar 2016 08:20:24 -0400 Message-ID: <1458130820.11443.1.camel@codethink.co.uk> Subject: Re: [PATCH] x86: dts: ce4100: Fix compatible string for PCF8575 chip From: Ben Hutchings To: linux-kernel@vger.kernel.org Cc: Jiang Liu Date: Wed, 16 Mar 2016 12:20:20 +0000 In-Reply-To: <1458130503.23053.10.camel@codethink.co.uk> References: <1458130503.23053.10.camel@codethink.co.uk> Organization: Codethink Ltd. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2435 Lines: 71 On Wed, 2016-03-16 at 12:15 +0000, Ben Hutchings wrote: > The binding definition for the PCF857x GPIO expanders doesn't mention > a "ti,pcf8575" compatible string. This is apparently because TI is > only a second source - there is no functional difference between > PCF8575 chips manufactured by TI and NXP, and the same board might be > populated with either depending on availability. > > As a practical matter, the gpio-pcf857x driver doesn't match this > string, so this device tree currently won't work. > > Signed-off-by: Ben Hutchings Append or replace that with: Signed-off-by: Ben Hutchings > --- > Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt | 4 ++-- > arch/x86/platform/ce4100/falconfalls.dts | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt b/Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt > index 569b16248514..1ff6f8487a2d 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt > @@ -71,7 +71,7 @@ This is an example which is used on FalconFalls: > /* This I2C controller has one gpio controller */ > gpio@26 { > #gpio-cells = <2>; > - compatible = "ti,pcf8575"; > + compatible = "nxp,pcf8575"; > reg = <0x26>; > gpio-controller; > }; > @@ -85,7 +85,7 @@ This is an example which is used on FalconFalls: > > gpio@26 { > #gpio-cells = <2>; > - compatible = "ti,pcf8575"; > + compatible = "nxp,pcf8575"; > reg = <0x26>; > gpio-controller; > }; > diff --git a/arch/x86/platform/ce4100/falconfalls.dts b/arch/x86/platform/ce4100/falconfalls.dts > index ce874f872cc6..4958e0045c34 100644 > --- a/arch/x86/platform/ce4100/falconfalls.dts > +++ b/arch/x86/platform/ce4100/falconfalls.dts > @@ -252,7 +252,7 @@ > > gpio@26 { > #gpio-cells = <2>; > - compatible = "ti,pcf8575"; > + compatible = "nxp,pcf8575"; > reg = <0x26>; > gpio-controller; > }; > @@ -266,7 +266,7 @@ > > gpio@26 { > #gpio-cells = <2>; > - compatible = "ti,pcf8575"; > + compatible = "nxp,pcf8575"; > reg = <0x26>; > gpio-controller; > }; > -- Ben Hutchings Software Developer, Codethink Ltd.