Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966648AbcCPNje (ORCPT ); Wed, 16 Mar 2016 09:39:34 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:33585 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932092AbcCPNjc (ORCPT ); Wed, 16 Mar 2016 09:39:32 -0400 Subject: Re: [PATCH 1/5] net: macb: Fix coding style error message To: Moritz Fischer References: <1457896247-25934-1-git-send-email-moritz.fischer@ettus.com> <1457896247-25934-2-git-send-email-moritz.fischer@ettus.com> CC: , , , , , From: Nicolas Ferre Organization: atmel Message-ID: <56E9621B.3090204@atmel.com> Date: Wed, 16 Mar 2016 14:39:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457896247-25934-2-git-send-email-moritz.fischer@ettus.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 33 Le 13/03/2016 20:10, Moritz Fischer a ?crit : > checkpatch.pl gave the following error: > > ERROR: space required before the open parenthesis '(' > + for(; p < end; p++, offset += 4) > > Signed-off-by: Moritz Fischer Acked-by: Nicolas Ferre > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 50c9410..4370f37 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -496,7 +496,7 @@ static void macb_update_stats(struct macb *bp) > > WARN_ON((unsigned long)(end - p - 1) != (MACB_TPF - MACB_PFR) / 4); > > - for(; p < end; p++, offset += 4) > + for (; p < end; p++, offset += 4) > *p += bp->macb_reg_readl(bp, offset); > } > > -- Nicolas Ferre