Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966701AbcCPNjx (ORCPT ); Wed, 16 Mar 2016 09:39:53 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:12659 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966265AbcCPNjv (ORCPT ); Wed, 16 Mar 2016 09:39:51 -0400 Subject: Re: [PATCH 0/5] net: macb: Checkpatch cleanups To: Moritz Fischer References: <1457896247-25934-1-git-send-email-moritz.fischer@ettus.com> CC: , , , , , From: Nicolas Ferre Organization: atmel Message-ID: <56E96225.2040508@atmel.com> Date: Wed, 16 Mar 2016 14:39:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457896247-25934-1-git-send-email-moritz.fischer@ettus.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 34 Le 13/03/2016 20:10, Moritz Fischer a ?crit : > Hi all, > > I backed out the variable scope changes and made a separate > patch for the ether_addr_copy change. > > Changes from v1: As it's v2, it's better to add it in each subject of the patch series like: "[PATCH v2 0/5] net: macb: Checkpatch cleanups" > * Backed out variable scope changes > * Separated out ether_addr_copy into it's own commit > * Fixed typo in comments as suggested by Joe > > Cheers, > > Moritz > > Moritz Fischer (5): > net: macb: Fix coding style error message > net: macb: Fix coding style warnings > net: macb: Address checkpatch 'check' suggestions > net: macb: Use ether_addr_copy over memcpy > net: macb: Fix simple typo. > > drivers/net/ethernet/cadence/macb.c | 153 +++++++++++++++++------------------- > 1 file changed, 70 insertions(+), 83 deletions(-) > -- Nicolas Ferre