Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966715AbcCPNp7 (ORCPT ); Wed, 16 Mar 2016 09:45:59 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:34313 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964787AbcCPNp4 (ORCPT ); Wed, 16 Mar 2016 09:45:56 -0400 Subject: Re: [PATCH 2/5] net: macb: Fix coding style warnings To: Michal Simek , Moritz Fischer References: <1457896247-25934-1-git-send-email-moritz.fischer@ettus.com> <1457896247-25934-3-git-send-email-moritz.fischer@ettus.com> <56E724BB.5030600@xilinx.com> CC: , , , , From: Nicolas Ferre Organization: atmel Message-ID: <56E9639B.7020007@atmel.com> Date: Wed, 16 Mar 2016 14:46:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E724BB.5030600@xilinx.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1899 Lines: 52 Le 14/03/2016 21:53, Michal Simek a ?crit : > On 13.3.2016 20:10, Moritz Fischer wrote: >> This commit takes care of the coding style warnings >> that are mostly due to a different comment style and >> lines over 80 chars, as well as a dangling else. >> >> Signed-off-by: Moritz Fischer >> --- >> drivers/net/ethernet/cadence/macb.c | 101 +++++++++++++++--------------------- >> 1 file changed, 43 insertions(+), 58 deletions(-) >> >> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c >> index 4370f37..c2d31c5 100644 >> --- a/drivers/net/ethernet/cadence/macb.c >> +++ b/drivers/net/ethernet/cadence/macb.c >> @@ -58,8 +58,7 @@ >> >> #define GEM_MTU_MIN_SIZE 68 >> >> -/* >> - * Graceful stop timeouts in us. We should allow up to >> +/* Graceful stop timeouts in us. We should allow up to >> * 1 frame time (10 Mbits/s, full-duplex, ignoring collisions) >> */ >> #define MACB_HALT_TIMEOUT 1230 >> @@ -127,8 +126,7 @@ static void hw_writel(struct macb *bp, int offset, u32 value) >> writel_relaxed(value, bp->regs + offset); >> } >> >> -/* >> - * Find the CPU endianness by using the loopback bit of NCR register. When the >> +/* Find the CPU endianness by using the loopback bit of NCR register. When the > > TBH: I would rather see this converting to kernel-doc format instead of > using this networking block. As there is hardly any kernel-doc comments in this driver, I won't force Moritz to move this one to it. I would advice, if someone want to move to kernel-doc for some function comments, to do it in a separate patch (series). > Also splitting this to more patches will be better. Just by categories > but that's just my opinion. Well, yes... but I won't be too picky for such a patch. So here is my: Acked-by: Nicolas Ferre Thank for your feedback, bye, -- Nicolas Ferre