Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966753AbcCPNsG (ORCPT ); Wed, 16 Mar 2016 09:48:06 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:14822 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966012AbcCPNsE (ORCPT ); Wed, 16 Mar 2016 09:48:04 -0400 Subject: Re: [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy To: Moritz Fischer References: <1457896247-25934-1-git-send-email-moritz.fischer@ettus.com> <1457896247-25934-5-git-send-email-moritz.fischer@ettus.com> CC: , , , , , From: Nicolas Ferre Organization: atmel Message-ID: <56E9641A.2020607@atmel.com> Date: Wed, 16 Mar 2016 14:48:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457896247-25934-5-git-send-email-moritz.fischer@ettus.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 31 Le 13/03/2016 20:10, Moritz Fischer a ?crit : > Checkpatch suggests using ether_addr_copy over memcpy > to copy the mac address. > > Signed-off-by: Moritz Fischer Yes: Acked-by: Nicolas Ferre > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 53400f6..a0c01e5 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -2891,7 +2891,7 @@ static int macb_probe(struct platform_device *pdev) > > mac = of_get_mac_address(np); > if (mac) > - memcpy(bp->dev->dev_addr, mac, ETH_ALEN); > + ether_addr_copy(bp->dev->dev_addr, mac); > else > macb_get_hwaddr(bp); > > -- Nicolas Ferre