Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966788AbcCPN5t (ORCPT ); Wed, 16 Mar 2016 09:57:49 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:33441 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934290AbcCPN5p (ORCPT ); Wed, 16 Mar 2016 09:57:45 -0400 Subject: Re: [PATCH v3 2/9] net: arc_emac: add phy reset is optional for device tree To: Caesar Wang , Heiko Stuebner , "David S. Miller" , Rob Herring References: <1457942520-12859-1-git-send-email-wxt@rock-chips.com> <1457942520-12859-3-git-send-email-wxt@rock-chips.com> Cc: linux-rockchip@lists.infradead.org, keescook@google.com, leozwang@google.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <56E96656.5000101@cogentembedded.com> Date: Wed, 16 Mar 2016 16:57:42 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457942520-12859-3-git-send-email-wxt@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 861 Lines: 24 Hello. On 3/14/2016 11:01 AM, Caesar Wang wrote: > This patch adds the following property for arc_emac. > > 1) phy-reset-gpios: > The phy-reset-gpio is an optional property for arc emac device tree boot. > Change the binding document to match the driver code. > > 2) phy-reset-duration: > Different boards may require different phy reset duration. Add property > phy-reset-duration for device tree probe, so that the boards that need > a longer reset duration can specify it in their device tree. > > Anyway, we can add the above property for arc emac. > > Signed-off-by: Caesar Wang Could you have a look at drivers/net/ethernet/cadence/macb/? It seems to be the only driver which places the PHY's "reset-gpios" prop correctly, into the PHY subnode? I'm currently working on adding support of this prop into phylib... MBR, Sergei