Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966749AbcCPOHQ (ORCPT ); Wed, 16 Mar 2016 10:07:16 -0400 Received: from kanga.kvack.org ([205.233.56.17]:37345 "EHLO kanga.kvack.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966111AbcCPOHO (ORCPT ); Wed, 16 Mar 2016 10:07:14 -0400 Date: Wed, 16 Mar 2016 10:07:13 -0400 From: Benjamin LaHaise To: Arnd Bergmann Cc: linuxppc-dev@lists.ozlabs.org, Andy Shevchenko , Stephen Rothwell , "linux-kernel@vger.kernel.org" , linux-next , Christoph Hellwig , Al Viro , Sudip Mukherjee Subject: Re: linux-next: build failure after merge of the aio tree Message-ID: <20160316140713.GC14746@kvack.org> References: <20160315174634.6766cd88@canb.auug.org.au> <15874870.hBfxUomX5V@wuerfel> <4892345.flKnDo9XDS@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4892345.flKnDo9XDS@wuerfel> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 20 On Wed, Mar 16, 2016 at 02:59:38PM +0100, Arnd Bergmann wrote: > On Wednesday 16 March 2016 13:12:36 Andy Shevchenko wrote: > > > > > I've also sent a patch that fixes the link error on ARM and that should > > > work on all other architectures too. > > > > In case of avr32 signalfd_read() fails. Does your patch help with it as well? > > > > P.S. Bisecting shows same culprit: 150a0b4905f1 ("aio: add support for > > async openat()") > > I don't know. What is the symptom on avr32? My patch only removes the > get_user() instances on 64-bit values and replaces them with a > single copy_from_user() call. Which is the wrong fix. Arch code should be able to handle 64 bit values in all the get/put_user() variants. We use 64 bit variables all over the place in interfaces to userspace. -ben