Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935058AbcCPOr7 (ORCPT ); Wed, 16 Mar 2016 10:47:59 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:36441 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933471AbcCPOr5 convert rfc822-to-8bit (ORCPT ); Wed, 16 Mar 2016 10:47:57 -0400 MIME-Version: 1.0 X-Originating-IP: [162.246.216.28] In-Reply-To: <1458129209-15449-1-git-send-email-afaerber@suse.de> References: <1458129209-15449-1-git-send-email-afaerber@suse.de> Date: Wed, 16 Mar 2016 11:47:56 -0300 Message-ID: Subject: Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example From: Javier Martinez Canillas To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: linux-input@vger.kernel.org, Heiko Stuebner , "linux-arm-kernel@lists.infradead.org" , Linux Kernel , Julien Chauveau , Geert Uytterhoeven , Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 23 Hello Andreas, On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber wrote: > Drop #address-cells and #size-cells, which are not required by the > gpio-keys binding documentation, as button sub-nodes are not devices. > > Rename sub-nodes to avoid new dtc unit address warnings when copied. > > While at it, adopt the dashes convention for the node name. > > Reported-by: Julien Chauveau > Cc: Julien Chauveau > Cc: Javier Martinez Canillas > Cc: Geert Uytterhoeven > Signed-off-by: Andreas Färber > --- Patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, Javier