Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966870AbcCPPQx (ORCPT ); Wed, 16 Mar 2016 11:16:53 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35827 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964860AbcCPPQv (ORCPT ); Wed, 16 Mar 2016 11:16:51 -0400 Date: Wed, 16 Mar 2016 16:17:38 +0100 From: Daniel Vetter To: Boris Brezillon Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/9] drm: atmel-hlcdc: add a ->cleanup_fb() operation Message-ID: <20160316151738.GQ14170@phenom.ffwll.local> Mail-Followup-To: Boris Brezillon , David Airlie , dri-devel@lists.freedesktop.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1458136663-21396-1-git-send-email-boris.brezillon@free-electrons.com> <1458136663-21396-2-git-send-email-boris.brezillon@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458136663-21396-2-git-send-email-boris.brezillon@free-electrons.com> X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3488 Lines: 93 On Wed, Mar 16, 2016 at 02:57:35PM +0100, Boris Brezillon wrote: > Add a ->cleanup_fb() operation to avoid memory leaks when the atomic > operation is interrupted after the ->prepare_fb() call. > > Signed-off-by: Boris Brezillon > Fixes 2389fc1 ("drm: atmel-hlcdc: Atomic mode-setting conversion") > Reviewed-by: Nicolas Ferre > Tested-by: Nicolas Ferre > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 ++ > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 22 +++++++++++++++++++--- > 2 files changed, 21 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > index fed517f..ec64140 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > @@ -81,11 +81,13 @@ struct atmel_hlcdc_plane_properties { > * @layer: HLCDC layer structure > * @properties: pointer to the property definitions structure > * @rotation: current rotation status > + * @prepared: flagging the plane has prepared for an atomic update > */ > struct atmel_hlcdc_plane { > struct drm_plane base; > struct atmel_hlcdc_layer layer; > struct atmel_hlcdc_plane_properties *properties; > + bool prepared; > }; > > static inline struct atmel_hlcdc_plane * > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > index 1ffe9c3..35027d0 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > @@ -715,11 +715,25 @@ static int atmel_hlcdc_plane_prepare_fb(struct drm_plane *p, > const struct drm_plane_state *new_state) > { > struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p); > + int ret; > > - if (!new_state->fb) > - return 0; > + ret = atmel_hlcdc_layer_update_start(&plane->layer); > + if (!ret) > + plane->prepared = true; Atomic helpers will keep track of this for you, and only call ->cleanup_fb on a plane combo where it did (successfully) call ->prepare_fb. -Daniel > + > + return ret; > +} > + > +static void atmel_hlcdc_plane_cleanup_fb(struct drm_plane *p, > + const struct drm_plane_state *old_state) > +{ > + struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p); > + > + if (!plane->prepared) > + return; > > - return atmel_hlcdc_layer_update_start(&plane->layer); > + atmel_hlcdc_layer_update_rollback(&plane->layer); > + plane->prepared = false; > } > > static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, > @@ -739,6 +753,7 @@ static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, > atmel_hlcdc_plane_update_disc_area(plane, state); > > atmel_hlcdc_layer_update_commit(&plane->layer); > + plane->prepared = false; > } > > static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p, > @@ -844,6 +859,7 @@ static void atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane, > > static struct drm_plane_helper_funcs atmel_hlcdc_layer_plane_helper_funcs = { > .prepare_fb = atmel_hlcdc_plane_prepare_fb, > + .cleanup_fb = atmel_hlcdc_plane_cleanup_fb, > .atomic_check = atmel_hlcdc_plane_atomic_check, > .atomic_update = atmel_hlcdc_plane_atomic_update, > .atomic_disable = atmel_hlcdc_plane_atomic_disable, > -- > 2.5.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch