Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966843AbcCPPfh (ORCPT ); Wed, 16 Mar 2016 11:35:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:53908 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935092AbcCPPff (ORCPT ); Wed, 16 Mar 2016 11:35:35 -0400 Date: Wed, 16 Mar 2016 16:35:33 +0100 Message-ID: From: Takashi Iwai To: Dan Carpenter Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, Quentin Lambert , kernel-janitors@vger.kernel.org, Takashi Iwai , linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [patch] ALSA: mixart: silence an uninitialized variable warning In-Reply-To: <20160316074213.GC12860@mwanda> References: <20160316074213.GC12860@mwanda> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 811 Lines: 31 On Wed, 16 Mar 2016 08:42:13 +0100, Dan Carpenter wrote: > > We could print the uninitialized value of "stat" in the error message. > > Signed-off-by: Dan Carpenter Applied, thanks. Takashi > > diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c > index bc81b9f..25c0ddd 100644 > --- a/sound/pci/mixart/mixart.c > +++ b/sound/pci/mixart/mixart.c > @@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr, > } > > if(start) { > - u32 stat; > + u32 stat = 0; > > group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */ > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >