Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754716AbcCPPzx (ORCPT ); Wed, 16 Mar 2016 11:55:53 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:35215 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbcCPPzu (ORCPT ); Wed, 16 Mar 2016 11:55:50 -0400 MIME-Version: 1.0 In-Reply-To: <1457621332-7821-1-git-send-email-jwboyer@fedoraproject.org> References: <1457621332-7821-1-git-send-email-jwboyer@fedoraproject.org> Date: Wed, 16 Mar 2016 11:55:49 -0400 X-Google-Sender-Auth: waQJDtKLpWKj3YT6kOd4ZU4n_rU Message-ID: Subject: Re: [PATCH] USB: serial: ftdi_sio: Add support for ICP DAS I-756xU devices From: Josh Boyer To: Johan Hovold Cc: Greg Kroah-Hartman , Linux USB Mailing List , "Linux-Kernel@Vger. Kernel. Org" , stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2226 Lines: 59 On Thu, Mar 10, 2016 at 9:48 AM, Josh Boyer wrote: > A Fedora user reports that the ftdi_sio driver works properly for the > ICP DAS I-7561U device. Further, the user manual for these devices > instructs users to load the driver and add the ids using the sysfs > interface. > > Add support for these in the driver directly so that the devices work > out of the box instead of needing manual configuration. > > Reported-by: > CC: stable > Signed-off-by: Josh Boyer > --- Anything further I need to do on this patch? josh > drivers/usb/serial/ftdi_sio.c | 4 ++++ > drivers/usb/serial/ftdi_sio_ids.h | 8 ++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c > index 8c660ae401d8..b61f12160d37 100644 > --- a/drivers/usb/serial/ftdi_sio.c > +++ b/drivers/usb/serial/ftdi_sio.c > @@ -1004,6 +1004,10 @@ static const struct usb_device_id id_table_combined[] = { > { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_DISPLAY_PID) }, > { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_LITE_PID) }, > { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_ANALOG_PID) }, > + /* ICP DAS I-756xU devices */ > + { USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) }, > + { USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) }, > + { USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) }, > { } /* Terminating entry */ > }; > > diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h > index a84df2513994..a4ec24ce6a11 100644 > --- a/drivers/usb/serial/ftdi_sio_ids.h > +++ b/drivers/usb/serial/ftdi_sio_ids.h > @@ -872,6 +872,14 @@ > #define NOVITUS_BONO_E_PID 0x6010 > > /* > + * ICPDAS I-756*U devices > + */ > +#define ICPDAS_VID 0x1b5c > +#define ICPDAS_I7560U_PID 0x0103 > +#define ICPDAS_I7561U_PID 0x0104 > +#define ICPDAS_I7563U_PID 0x0105 > + > +/* > * RT Systems programming cables for various ham radios > */ > #define RTSYSTEMS_VID 0x2100 /* Vendor ID */ > -- > 2.5.0 >