Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754207AbcCPQC6 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Mar 2016 12:02:58 -0400
Received: from imap.thunk.org ([74.207.234.97]:51992 "EHLO imap.thunk.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750919AbcCPQCz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Mar 2016 12:02:55 -0400
Date: Wed, 16 Mar 2016 12:02:48 -0400
From: "Theodore Ts'o" <tytso@mit.edu>
To: Doug Ledford <dledford@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Mike Marciniszyn <infinipath@intel.com>,
        linux-rdma@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Dennis Dalessandro <dennis.dalessandro@intel.com>,
        ira weiny <ira.weiny@intel.com>, Jubin John <jubin.john@intel.com>
Subject: Re: [WTF] utterly tasteless ABI in hfi1 (around
 ->write()/->write_iter())
Message-ID: <20160316160248.GE23593@thunk.org>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>,
	Doug Ledford <dledford@redhat.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Mike Marciniszyn <infinipath@intel.com>, linux-rdma@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Dennis Dalessandro <dennis.dalessandro@intel.com>,
	ira weiny <ira.weiny@intel.com>, Jubin John <jubin.john@intel.com>
References: <20160316041717.GJ17997@ZenIV.linux.org.uk>
 <56E97FD7.9020007@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56E97FD7.9020007@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tytso@thunk.org
X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1808
Lines: 34

On Wed, Mar 16, 2016 at 11:46:31AM -0400, Doug Ledford wrote:
> I can't speak for Mike, but I never said "It's Special".  I said it's a
> driver internal thing with only one consumer and the kernel driver and
> the user space consumer are a matched pair.  If this were a general API
> for use by any old program I would agree with you, but since it isn't, I
> wasn't that concerned about whether it got fixed.  If it broke, Intel
> had both pieces and could fix it.  And with that in mind I said "ince
> this is an internal driver interface that only Intel uses, I'm not
> inclined to force them to rewrite their driver and their library just
> because their particular usage took you off guard."

The thing which is really scary about the "we own both pieces, so we
can be sloppy with the interface design" is there is the question of
whether there are any security issues with such an interface.  Maybe
the assumption is that only root will get to access the interface, but
as we're seeing with user namespaces, very often these assumptions are
getting upended.

So certainly if I were a bad guy working at the NSA^H^H^H^H KGB trying
to find a zero-day that I would keep in my agency's back pocket,
interfaces designed with this kind of attitude would be the first
place I would look.

> For the hfi1 driver (and OPA in general), we do have the ability to do a
> new API.  But, going back to what I said before, I just don't care that
> much.  It's Intel internal stuff as far as I'm concerned.  If they do
> something fragile and it breaks, then that's all on their hands.

Except if there's a security vulernability, then it's on our
collective heads as kernel developers.  Unless we want to tell people,
"don't use intel hardware, it's written by device driver authors who
are sloppy"....

							- Ted