Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932791AbcCPQzf (ORCPT ); Wed, 16 Mar 2016 12:55:35 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:35926 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753166AbcCPQzc (ORCPT ); Wed, 16 Mar 2016 12:55:32 -0400 Date: Wed, 16 Mar 2016 16:55:26 +0000 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ohad@wizery.com, devicetree@vger.kernel.org, f.fainelli@gmail.com, kernel@stlinux.com, Nathan_Lynch@mentor.com, s-anna@ti.com Subject: Re: [STLinux Kernel] [PATCH v5 7/7] ARM: STiH407: Move over to using the 'reserved-memory' API for obtaining DMA memory Message-ID: <20160316165526.GZ13692@x1> References: <1452602781-22424-1-git-send-email-lee.jones@linaro.org> <1452602781-22424-8-git-send-email-lee.jones@linaro.org> <20160316163508.GA8396@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160316163508.GA8396@griffinp-ThinkPad-X1-Carbon-2nd> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2682 Lines: 79 On Wed, 16 Mar 2016, Peter Griffin wrote: > Hi Lee, > > On Tue, 12 Jan 2016, Lee Jones wrote: > > > Doing so saves quite a bit of code in the driver. > > > > For more information on the 'reserved-memory' bindings see: > > > > Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > > > > Suggested-by: Suman Anna > > Signed-off-by: Lee Jones > > --- > > arch/arm/boot/dts/stih407-family.dtsi | 46 +++++++++++++++++++++++++++++------ > > 1 file changed, 38 insertions(+), 8 deletions(-) > > > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > > index 15c20b6..27b8efc 100644 > > --- a/arch/arm/boot/dts/stih407-family.dtsi > > +++ b/arch/arm/boot/dts/stih407-family.dtsi > > @@ -15,6 +15,36 @@ > > #address-cells = <1>; > > #size-cells = <1>; > > > > + reserved-memory { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > + gp0_reserved: rproc@40000000 { > > + compatible = "shared-dma-pool"; > > + reg = <0x40000000 0x01000000>; > > + no-map; > > + }; > > + > > + gp1_reserved: rproc@41000000 { > > + compatible = "shared-dma-pool"; > > + reg = <0x41000000 0x01000000>; > > + no-map; > > + }; > > + > > + audio_reserved: rproc@42000000 { > > + compatible = "shared-dma-pool"; > > + reg = <0x42000000 0x01000000>; > > + no-map; > > + }; > > + > > + dmu_reserved: rproc@43000000 { > > + compatible = "shared-dma-pool"; > > + reg = <0x43000000 0x01000000>; > > + no-map; > > + }; > > I don't believe these reserved memory ranges are correct for audio_reserved and dmu_reserved. > > For example my vid_firmware-stih407.elf is linked at 0x41c00000 base address and my > audio_firmware-bd-stih407.elf is linked at 0x40c00000. > > So with all the st231 rproc nodes enabled I guess it would still work. But > currently I think st231_gp0 is reserving the memory region for st231_audio, > and st231-gp1 is reserving the memory region for st231_dmu. These addresses are taken from internally tested code. I don't have access to the LMI layout documentation (if it even exists) so can't check for myself. Isn't this just DDR anyway? So in theory we can configure each devices' slice where ever we feel is appropriate? How is memory allocated to the DMU and Audio drivers? Do you have scripts which link the aforementioned binaries? If you think there is an issue, I suggest the best thing to do is ping Ludovic, since he is the author of the original code. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog