Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934833AbcCPRuX (ORCPT ); Wed, 16 Mar 2016 13:50:23 -0400 Received: from smtpoutz299.laposte.net ([178.22.154.199]:36176 "EHLO smtp.laposte.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933085AbcCPRuW (ORCPT ); Wed, 16 Mar 2016 13:50:22 -0400 X-Greylist: delayed 1458 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Mar 2016 13:50:21 EDT Message-ID: <56E99727.9040702@laposte.net> Date: Wed, 16 Mar 2016 18:25:59 +0100 From: Sebastian Frias User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , "David S. Miller" , netdev@vger.kernel.org CC: lkml , mason Subject: [PATCH] net: phy: at803x: don't depend on GPIOLIB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-VR-SrcIP: 83.142.147.193 X-VR-FullState: 0 X-VR-Score: -100 X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrfeekkedrtddvgddutddtucetufdoteggodetrfdotffvucfrrhho X-VR-Cause-2: fhhilhgvmecunfetrffquffvgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhht X-VR-Cause-3: shculddquddttddmnecujfgurhepkfffhfgfggfvufgtgfesthejrgdttdefjeenucfhrhhomhepufgv X-VR-Cause-4: sggrshhtihgrnhcuhfhrihgrshcuoehsfhekgeeslhgrphhoshhtvgdrnhgvtheqnecukfhppeekfedr X-VR-Cause-5: udegvddrudegjedrudelfeenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopegludej X-VR-Cause-6: vddrvdejrddtrddvudegngdpihhnvghtpeekfedrudegvddrudegjedrudelfedpmhgrihhlfhhrohhm X-VR-Cause-7: pehsfhekgeeslhgrphhoshhtvgdrnhgvthdprhgtphhtthhopehurdhklhgvihhnvgdqkhhovghnihhg X-VR-Cause-8: sehpvghnghhuthhrohhnihigrdguvg X-VR-AvState: No X-VR-State: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1069 Lines: 33 Commit 687908c2b649 ("net: phy: at803x: simplify using devm_gpiod_get_optional and its 4th argument") introduced a dependency on GPIOLIB that was not there before. This commit removes such dependency by checking the return code and comparing it against ENOSYS which is returned when GPIOLIB is not selected. Fixes: 687908c2b649 ("net: phy: at803x: simplify using devm_gpiod_get_optional and its 4th argument") Signed-off-by: Sebastian Frias --- drivers/net/phy/at803x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index 2174ec9..88b7ff3 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -252,7 +252,9 @@ static int at803x_probe(struct phy_device *phydev) return -ENOMEM; gpiod_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); - if (IS_ERR(gpiod_reset)) + if (PTR_ERR(gpiod_reset) == -ENOSYS) + gpiod_reset = NULL; + else if (IS_ERR(gpiod_reset)) return PTR_ERR(gpiod_reset); priv->gpiod_reset = gpiod_reset; -- 2.1.4