Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755462AbcCPR5n (ORCPT ); Wed, 16 Mar 2016 13:57:43 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:46955 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756AbcCPR5l (ORCPT ); Wed, 16 Mar 2016 13:57:41 -0400 Date: Wed, 16 Mar 2016 11:57:26 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen , Stefan Berger Cc: Arnd Bergmann , Peter Huewe , Marcel Selhorst , "Hon Ching (Vicky) Lo" , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm: fix tpm_bios_log_setup stub prototype Message-ID: <20160316175726.GB6127@obsidianresearch.com> References: <1458116410-3208536-1-git-send-email-arnd@arndb.de> <20160316101341.GA4051@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160316101341.GA4051@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1209 Lines: 25 On Wed, Mar 16, 2016 at 12:13:41PM +0200, Jarkko Sakkinen wrote: > On Wed, Mar 16, 2016 at 09:19:48AM +0100, Arnd Bergmann wrote: > > A cleanup patch changed the prototype of the regular tpm_bios_log_setup > > function, but not that of the stub that is used when the TPM is disabled, > > causing a harmless build warning: > > > > drivers/char/tpm/tpm-chip.c: In function 'tpm1_chip_register': > > drivers/char/tpm/tpm-chip.c:287:38: error: passing argument 1 of 'tpm_bios_log_setup' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] > > chip->bios_dir = tpm_bios_log_setup(dev_name(&chip->dev)); > > In file included from ../drivers/char/tpm/tpm-chip.c:30:0: > > ../drivers/char/tpm/tpm_eventlog.h:83:31: note: expected 'char *' but argument is of type 'const char *' > > static inline struct dentry **tpm_bios_log_setup(char *name) > > > > This changes the stub function to match the normal prototype, > > avoiding that warning. > > Good catch. Thank you. The weird thing is I already applied this hunk to the patch, an autobuilder found it, it is right in my personal tree.. Unclear where it got dropped? Are we missing anything else in that series? Stephen? Jason