Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935230AbcCPSWU (ORCPT ); Wed, 16 Mar 2016 14:22:20 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:34922 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934879AbcCPSWS (ORCPT ); Wed, 16 Mar 2016 14:22:18 -0400 Subject: Re: [PATCH 3/5] ARM: davinci: da8xx: add cfgchip2 to resources To: David Lechner , Sekhar Nori , Kevin Hilman , Alan Stern , Bin Liu , Petr Kulhavy References: <1458081473-8223-1-git-send-email-david@lechnology.com> <1458081473-8223-3-git-send-email-david@lechnology.com> <56E8906E.7070800@cogentembedded.com> <56E8D720.7000508@lechnology.com> <56E8E7C7.70901@lechnology.com> <56E99A16.9020709@cogentembedded.com> <56E9A282.7030103@lechnology.com> Cc: Russell King , Greg Kroah-Hartman , Felipe Balbi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56E9A456.2000204@cogentembedded.com> Date: Wed, 16 Mar 2016 21:22:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E9A282.7030103@lechnology.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 24 On 03/16/2016 09:14 PM, David Lechner wrote: >>> Also, I am not finding any existing data structure to pass the musb >>> set_mode >>> function to the phy in either usb_phy or usb_otg. Setting the mode >>> (host/peripheral/otg) is done in the same PHY register, so it seems >>> like it >>> should be implemented in the new phy driver as well. >> >> Perhaps we'd have to sacrifice that functionality... > > The device I am working on (LEGO MINDSTORMS EV3) has the port wired as > peripheral only, so I don't think leaving this out is an option. Leaving it in > OTG mode doesn't work because the required electrical connections are just not > there. The set_mode() method doesn't have anything to do with the predefined roles. What CFGCHIP2 setting do is to override the ID input (and also the VBUS level comparator). This is not required for the normal functioning of either host or peripheral AFAIR. [...] MBR, Sergei