Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935365AbcCPS1o (ORCPT ); Wed, 16 Mar 2016 14:27:44 -0400 Received: from vern.gendns.com ([206.190.152.46]:55447 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934911AbcCPS1l (ORCPT ); Wed, 16 Mar 2016 14:27:41 -0400 Subject: Re: [PATCH 3/5] ARM: davinci: da8xx: add cfgchip2 to resources To: Sergei Shtylyov , Sekhar Nori , Kevin Hilman , Alan Stern , Bin Liu , Petr Kulhavy References: <1458081473-8223-1-git-send-email-david@lechnology.com> <1458081473-8223-3-git-send-email-david@lechnology.com> <56E8906E.7070800@cogentembedded.com> <56E8D720.7000508@lechnology.com> <56E8E7C7.70901@lechnology.com> <56E99A16.9020709@cogentembedded.com> <56E9A282.7030103@lechnology.com> <56E9A456.2000204@cogentembedded.com> Cc: Russell King , Greg Kroah-Hartman , Felipe Balbi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org From: David Lechner Message-ID: <56E9A598.40308@lechnology.com> Date: Wed, 16 Mar 2016 13:27:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56E9A456.2000204@cogentembedded.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 481 Lines: 11 On 03/16/2016 01:22 PM, Sergei Shtylyov wrote: > > The set_mode() method doesn't have anything to do with the > predefined roles. What CFGCHIP2 setting do is to override the ID input > (and also the VBUS level comparator). This is not required for the > normal functioning of either host or peripheral AFAIR. > OK, so it sounds like I should just remove set_mode from the musb driver completely and make this configurable in the phy driver via platform data or device tree.