Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965805AbcCPV4M (ORCPT ); Wed, 16 Mar 2016 17:56:12 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35134 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965007AbcCPV4D convert rfc822-to-8bit (ORCPT ); Wed, 16 Mar 2016 17:56:03 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Subject: Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example From: Julien Chauveau In-Reply-To: Date: Wed, 16 Mar 2016 22:55:53 +0100 Cc: =?utf-8?Q?Andreas_F=C3=A4rber?= , linux-input@vger.kernel.org, Heiko Stuebner , "linux-arm-kernel@lists.infradead.org" , Linux Kernel , Geert Uytterhoeven , Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Transfer-Encoding: 8BIT Message-Id: References: <1458129209-15449-1-git-send-email-afaerber@suse.de> To: Javier Martinez Canillas X-Mailer: Apple Mail (2.3112) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 916 Lines: 27 > Le 16 mars 2016 à 15:47, Javier Martinez Canillas a écrit : > > Hello Andreas, > > On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber wrote: >> Drop #address-cells and #size-cells, which are not required by the >> gpio-keys binding documentation, as button sub-nodes are not devices. >> >> Rename sub-nodes to avoid new dtc unit address warnings when copied. >> >> While at it, adopt the dashes convention for the node name. >> >> Reported-by: Julien Chauveau >> Cc: Julien Chauveau >> Cc: Javier Martinez Canillas >> Cc: Geert Uytterhoeven >> Signed-off-by: Andreas Färber >> --- > > Patch looks good to me. > > Reviewed-by: Javier Martinez Canillas I agree. Reviewed-by: Julien Chauveau