Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935285AbcCPWj0 (ORCPT ); Wed, 16 Mar 2016 18:39:26 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:52317 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932524AbcCPWjY (ORCPT ); Wed, 16 Mar 2016 18:39:24 -0400 Date: Wed, 16 Mar 2016 23:39:16 +0100 From: Peter Zijlstra To: "Rafael J. Wysocki" Cc: Linux PM list , Juri Lelli , Steve Muckle , ACPI Devel Maling List , Linux Kernel Mailing List , Srinivas Pandruvada , Viresh Kumar , Vincent Guittot , Michael Turquette , Ingo Molnar Subject: Re: [PATCH v4 7/7] cpufreq: schedutil: New governor based on scheduler utilization data Message-ID: <20160316223916.GK6344@twins.programming.kicks-ass.net> References: <1711281.bPmSjlBT7c@vostro.rjw.lan> <11678919.CQLTrQTYxG@vostro.rjw.lan> <20160316175211.GF6344@twins.programming.kicks-ass.net> <1520262.pnveEYDEnp@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1520262.pnveEYDEnp@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 609 Lines: 14 On Wed, Mar 16, 2016 at 10:38:14PM +0100, Rafael J. Wysocki wrote: > > If you care what cpu the work runs on, you should schedule_work_on(), > > regular schedule_work() can end up on any random cpu (although typically > > it does not). > > I know, but I don't care too much. > > "ondemand" and "conservative" use schedule_work() for the same thing, so > drivers need to cope with that if they need things to run on a particular > CPU. Or are just plain buggy -- like a lot of code that uses schedule_work() for per-cpu thingies; that is, its a fairly common bug and only recently did we add that RR thing.