Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967003AbcCPXYu (ORCPT ); Wed, 16 Mar 2016 19:24:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:40485 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966885AbcCPXYs (ORCPT ); Wed, 16 Mar 2016 19:24:48 -0400 Subject: Re: [PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses. To: David Daney References: <1457718791-6505-1-git-send-email-ddaney.cavm@gmail.com> <1457718791-6505-4-git-send-email-ddaney.cavm@gmail.com> <56E9E343.3080207@suse.de> <56E9E43A.6000304@caviumnetworks.com> Cc: Mark Rutland , Florian Fainelli , Robert Richter , Pawel Moll , Ian Campbell , netdev@vger.kernel.org, David Daney , linux-kernel@vger.kernel.org, Rob Herring , David Daney , Kumar Gala , Sunil Goutham , Radha Mohan Chintakuntla , "David S. Miller" , linux-arm-kernel@lists.infradead.org From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <56E9EB3D.6050406@suse.de> Date: Thu, 17 Mar 2016 00:24:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E9E43A.6000304@caviumnetworks.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1329 Lines: 42 Am 16.03.2016 um 23:54 schrieb David Daney: > On 03/16/2016 03:50 PM, Andreas F?rber wrote: >> Am 11.03.2016 um 18:53 schrieb David Daney: >>> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig >>> index 40faec9..075a4cc 100644 >>> --- a/drivers/net/phy/Kconfig >>> +++ b/drivers/net/phy/Kconfig >>> @@ -196,6 +196,17 @@ config MDIO_OCTEON >>> buses. It is required by the Octeon and ThunderX ethernet device >>> drivers on some systems. >>> >>> +config MDIO_THUNDER >>> + tristate "Support for MDIO buses on on ThunderX SOCs" >> >> Double "on", spotted in next-20160316. >> >>> + depends on 64BIT >>> + depends on PCI >>> + select MDIO_CAVIUM >>> + help >>> + This driver supports the MDIO interfaces found on Cavium >>> + ThunderX SoCs when the MDIO bus device appears on as a PCI >>> + device. >> >> While at it, this sentence sounds weird. Did you mean s/as/is/? Or is >> there another verb missing in there? > > Should be "... appears as a PCI device." > > davem already merged the patch, so this would have to be fixed as a > follow-on patch. > > Since you found this, do you want to send the patch? Done. Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)