Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756217AbcCQBkq (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Mar 2016 21:40:46 -0400
Received: from mail-pf0-f193.google.com ([209.85.192.193]:33334 "EHLO
	mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755406AbcCQBko (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Mar 2016 21:40:44 -0400
Subject: Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to
 4KB regardless of system page size"
To: Or Gerlitz <gerlitz.or@gmail.com>
References: <1458037148-4475-1-git-send-email-aik@ozlabs.ru>
 <CAJ3xEMhxUuQj+E00fa-tEKz+dVzDqFspC80Z=k7UPZpOP30H3g@mail.gmail.com>
 <56E8BFFE.9000803@ozlabs.ru> <20160316051021.GC66645@x-vnc01.mtx.labs.mlnx>
 <56E8F3CC.3070203@ozlabs.ru> <20160316060947.GD66645@x-vnc01.mtx.labs.mlnx>
 <56E91A78.5000700@ozlabs.ru>
 <CAJ3xEMgorN4r-Ls66rc3VwUBi=uhb==ih2=43ujrbPC=ts8E5g@mail.gmail.com>
Cc: Eli Cohen <eli@mellanox.com>, Huy Nguyen <huyn@mellanox.com>,
        Doug Ledford <dledford@redhat.com>,
        Eugenia Emantayev <eugenia@mellanox.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        Sean Hefty <sean.hefty@intel.com>, Yishai Hadas <yishaih@mellanox.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        Linux Netdev List <netdev@vger.kernel.org>,
        Paul Mackerras <paulus@samba.org>, Carol L Soto <clsoto@us.ibm.com>,
        Yevgeny Petrilin <yevgenyp@mellanox.com>,
        Brian J King <bjking1@us.ibm.com>
From: Alexey Kardashevskiy <aik@ozlabs.ru>
Message-ID: <56EA0B12.3070901@ozlabs.ru>
Date: Thu, 17 Mar 2016 12:40:34 +1100
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <CAJ3xEMgorN4r-Ls66rc3VwUBi=uhb==ih2=43ujrbPC=ts8E5g@mail.gmail.com>
Content-Type: text/plain; charset=koi8-r; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 796
Lines: 21

On 03/16/2016 08:45 PM, Or Gerlitz wrote:
> On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>
>> Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not
>> work in a guest:
>
> So where is the breakage point for you? does 4.4 works? if not, what?

Ah, my bad. It is unrelated to the kernel version.

I tried passing a PF to a guest while its VFs are already passed to another 
guest and see how exactly it blows up (AER/EEH were thrown but the host 
recovered => good) but this left the device in a weird state when I could 
not use VF in a guest anymore but it seemed to keep working on the host.

It seems like the actual adapter does not reset completely when the machine 
is rebooted, I had unplug/replug power cables to fix this.


-- 
Alexey