Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753610AbcCQE2a (ORCPT ); Thu, 17 Mar 2016 00:28:30 -0400 Received: from mail-vk0-f47.google.com ([209.85.213.47]:36083 "EHLO mail-vk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752221AbcCQE22 (ORCPT ); Thu, 17 Mar 2016 00:28:28 -0400 MIME-Version: 1.0 In-Reply-To: <1458128433-3020-1-git-send-email-jszhang@marvell.com> References: <1458128433-3020-1-git-send-email-jszhang@marvell.com> Date: Thu, 17 Mar 2016 09:58:26 +0530 Message-ID: Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc() From: Pratyush Anand To: Jisheng Zhang Cc: Jingoo Han , Bjorn Helgaas , "linux-pci@vger.kernel.org" , linux-kernel@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 17 On Wed, Mar 16, 2016 at 5:10 PM, Jisheng Zhang wrote: > dw_pcie_setup_rc(), as its name indicates, setups the RC. But current > dw_pcie_host_init() also contains some necessary rc setup code. > > Another reason: the host may lost power during suspend to ram, the RC > need to be re-setup after resume. The rc can't be correctly resumed > without the rc setup code in dw_pcie_host_init(). > > So this patch moves the code to dw_pcie_setup_rc() to address the above > two issues. After this patch, each pcie designware driver users could > call dw_pcie_setup_rc() to re-setup rc when resume back. > > Signed-off-by: Jisheng Zhang Seems reasonable. Thanks for the cleanup. :-) Acked-by: Pratyush Anand